Dem insertion from file #1054
Merged
Dem insertion from file #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
requested changes
Mar 5, 2024
examples/sharp-immersed-boundary/sedimentation-64-particles/particles.input
Outdated
Show resolved
Hide resolved
acdaigneault
reviewed
Mar 5, 2024
OGaboriault
force-pushed
the
dem_insertion_from_file
branch
from
245e4ed
to
375040e
Compare
blaisb
approved these changes
Mar 8, 2024
|
I am good with it so @acdaigneault if you are good I think this is ready for merge |
acdaigneault
requested changes
Mar 9, 2024
Audrey's first batch of comments Co-authored-by: Audrey Collard-Daigneault <71884806+acdaigneault@users.noreply.github.com>
|
@OGaboriault some parameter files need to be updated I think |
blaisb
approved these changes
Mar 10, 2024
acdaigneault
approved these changes
Mar 11, 2024
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem Particle insertion can take a lot of time. Currently, it's not possible to change the triangulation being used before and after a restart. If it was possible to load particle with a certain triangulation (ex. enabling bigger insertion boxes and smaller cells) and running the rest of the simulation with the real triangulation, this could possibly save a lot of time. Description of the solution This PR adds the from_file insertion method. It's really similar to what has been done in the CFD-DEM Resolve solver. Basically, particles properties are stored in a text file. Each line is associated with a particle and each columns to a kind of properties. It's basically the same thing as the list insertion but without the limitation from the number of character on a single line. I've also include a python code to extract the properties of the last vtu of a simulation. How Has This Been Tested? I ran one of my pp_jkr application test to see if the result was affected by this method, which is not the case. I also extracted the properties of all the particles from one of my LPBF simulations. (1.2 million to be exact) and it worked. It took about 20 seconds. Documentation Insertion section. Co-authored-by: Audrey Collard-Daigneault <71884806+acdaigneault@users.noreply.github.com> Former-commit-id: 2d7ab84
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem Particle insertion can take a lot of time. Currently, it's not possible to change the triangulation being used before and after a restart. If it was possible to load particle with a certain triangulation (ex. enabling bigger insertion boxes and smaller cells) and running the rest of the simulation with the real triangulation, this could possibly save a lot of time. Description of the solution This PR adds the from_file insertion method. It's really similar to what has been done in the CFD-DEM Resolve solver. Basically, particles properties are stored in a text file. Each line is associated with a particle and each columns to a kind of properties. It's basically the same thing as the list insertion but without the limitation from the number of character on a single line. I've also include a python code to extract the properties of the last vtu of a simulation. How Has This Been Tested? I ran one of my pp_jkr application test to see if the result was affected by this method, which is not the case. I also extracted the properties of all the particles from one of my LPBF simulations. (1.2 million to be exact) and it worked. It took about 20 seconds. Documentation Insertion section. Co-authored-by: Audrey Collard-Daigneault <71884806+acdaigneault@users.noreply.github.com> Former-commit-id: 2d7ab84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution
This PR adds the
from_fileinsertion method. It's really similar to what has been done in the CFD-DEM Resolve solver. Basically, particles properties are stored in a text file. Each line is associated with a particle and each columns to a kind of properties.It's basically the same thing as the
listinsertion but without the limitation from the number of character on a single line.I've also include a python code to extract the properties of the last vtu of a simulation.
How Has This Been Tested?
Documentation