-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for libraw snapshots #107
Conversation
The OSX build failed; as expected. So I'll look into debugging delocate to see if something can be done about it. |
4096f94
to
a89dd16
Compare
Signed-off-by: Harshit Dwivedi <harshit@pitech.app>
dce13d8
to
c22421d
Compare
@letmaik Looks like it's trying to copy libjpeg from 2 different places indeed!
While the error makes sense on my local machine since I have already installed libjpeg with brew, it shouldn't be happening in a CI environment. |
OK, interesting. Thanks for debugging this! What your log doesn't show is which library is depending on libjpeg. On Linux getting this info is trivial with ldtree. Maybe otool for macOS can do something similar? Either way figuring out the complete dependency chain is vital and I think worth to dump to CI for future analysis. |
I tried otooling all the dylibs that rawpy ships with and it seems like libjpeg is a dpendency of both libraw and libjasper. Libraw picks the libjpeg shipped with rawpy whereas libjasper picks the one in /usr/local/opt
|
Good job, I think I know what's going on. Basically, we build libjpeg ourselves but then don't tell cmake about it when building libjasper. I moved the |
Alright, all green again :) Just merge in the current |
Sounds like a plan! |
Oh, and while we're at it; can we build and package version 14.0.0 of libjpeg instead of 13.0.0? Not a big deal, but if rawpy works well with version 14, then no reason to have it ship version 13, right? |
Sure, I don't mind. I'm assuming v14 is equivalent to v9d at http://ijg.org/files/? If so, can you open a separate PR that bumps the version? |
Yep, certainly. |
Similarly to Windows we may want to think about building static libraries only for the dependencies on macOS. This would avoid such conflicts. |
Fair enough, that makes sense. |
@letmaik I think this is good for merge. |
Fixes #106
Signed-off-by: Harshit Dwivedi harshit@pitech.app