-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for libraw snapshots? #106
Comments
What you say makes sense in principle. In practical terms, it means a few things:
I think the critical bit is maintenance effort that comes with frequent (dev) releases, especially based on master. If you like to help out with this and become a maintainer then I'm happy to go forward with your plan. |
Sounds like a plan! However, maybe weekly builds would be a bit too much. How do you suggest that we take this forward? |
OK, that makes sense. Not having automated weeklies/nightlies makes it easier. I would suggest to create a new branch Currently, releases of rawpy are triggered by pushing a git tag starting with So, to get started, I created the |
Sounds good, let me work on this. |
I tagged v0.15.0a1 and the new pre-release is up on PyPI. I also updated the README to say what a pre-release is and how to install it. |
I was looking at libraw snapshots and it seems like they added support for reading Canon CR3 files and a few more camera supports in their 0.20 snapshot build.
While I understand that you don't want to add support for non-stable releases of libraw, but quoting from the release cycle of libraw: LibRaw/LibRaw#191 (comment)
Waiting 1-1.5 years to get the changes in the snapshot build seems a bit too much imo; and as quoted by other sources (microsoft/vcpkg#6759), it seems like their snapshots are stable enough for normal use.
The only reason it's not released is that libraw doesn't publish a release unless all the features planned for the release have been finished: LibRaw/LibRaw#205 (comment)
My suggestion:
Have the current rawpy release (0.14) as it is and add a new snapshot release incorporating changes from the snapshots released by libraw.
As it would be a beta release, those who don't want to use it can get the 0.14 release via pip install.
Also since libraw snapshots are released once every 4-5 months, keeping up with their snapshot releases won't be much of a hassle anyways.
Let me know if this sounds good to you, it'll really save a lot of time for most of the people using rawpy and dealing with issues like #105.
Thanks again!
The text was updated successfully, but these errors were encountered: