Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Request in Data Transformations. #2351

Closed
Budman1758 opened this issue Feb 25, 2019 · 8 comments · Fixed by #3094
Closed

Small Request in Data Transformations. #2351

Budman1758 opened this issue Feb 25, 2019 · 8 comments · Fixed by #3094

Comments

@Budman1758
Copy link

In reference see this issue.
https://github.com/letscontrolit/ESPEasy/pull/1289

My request is to make a very minor change. See this section...

Transformations:

Special:
!: negate (only for 0 or 1)
R: RIGHT JUSTIFY

V: value
O: ON/OFF
C: OPEN/CLOSE <<<<< Change this to "CLOSED"
U: UP/DOWN

Methinks this would make a bit more sense. My use case is a valve that is either "OPEN" or "CLOSED"
CLOSE is not quite as informative and in some cases could be construed as being "near"

Just a wee little thing... :)

@TD-er
Copy link
Member

TD-er commented Feb 25, 2019

So this is one only for the wiki/ReadTheDocs I assume?

@Budman1758
Copy link
Author

No. The output is "CLOSE" as it is now. Would like it to be "CLOSED" Thats what the code outputs now. One would also need to update the Wiki also. :)

@TD-er
Copy link
Member

TD-er commented Feb 25, 2019

Hmm if it will be changed in the code, then it may break some existing rules.

@uzi18
Copy link
Contributor

uzi18 commented Feb 25, 2019

CLOSED also use 1 char more on LCD display.

@Grovkillen
Copy link
Member

Grovkillen commented Feb 25, 2019 via email

@TD-er
Copy link
Member

TD-er commented Feb 25, 2019

[...] But for a native American I'd say Bud got the upper hand in the correctness of the grammar 😎

Native American? ;)

@Grovkillen
Copy link
Member

Grovkillen commented Feb 25, 2019 via email

@Budman1758
Copy link
Author

[Native American? ;)

Well.... Not exactly. :) We weren't very nice to those folks..... To put it mildly..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants