New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small Request in Data Transformations. #2351
Comments
So this is one only for the wiki/ReadTheDocs I assume? |
No. The output is "CLOSE" as it is now. Would like it to be "CLOSED" Thats what the code outputs now. One would also need to update the Wiki also. :) |
Hmm if it will be changed in the code, then it may break some existing rules. |
CLOSED also use 1 char more on LCD display. |
It's "only" the string for displays and other outputs that will be
effected. So probably rules will work but like Uzi says, it will add one
more character. But for a native American I'd say Bud got the upper hand in
the correctness of the grammar 😎
Den mån 25 feb. 2019 19:44Gijs Noorlander <notifications@github.com> skrev:
… Hmm if it will be changed in the code, then it may break some existing
rules.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2351 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZeBYlOJ4UazNU6-JgydBcTxlfA0rjWGks5vRC7_gaJpZM4bPHlH>
.
|
|
Yep, I'm obviously not ;)
Den mån 25 feb. 2019 20:21Gijs Noorlander <notifications@github.com> skrev:
… [...] But for a native American I'd say Bud got the upper hand in the
correctness of the grammar 😎
Native American?
<https://www.google.com/search?q=native+American&rlz=1C1GGRV_enNL751NL751&source=lnms&tbm=isch&sa=X&ved=0ahUKEwiz98mjzdfgAhVEaFAKHahFB_EQ_AUIDigB&biw=1920&bih=1008>
;)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2351 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZeBYog0LnV1p6SWcfXx7PtMdsosrCgxks5vRDexgaJpZM4bPHlH>
.
|
Well.... Not exactly. :) We weren't very nice to those folks..... To put it mildly.. |
In reference see this issue.
https://github.com/letscontrolit/ESPEasy/pull/1289
My request is to make a very minor change. See this section...
Special:
!: negate (only for 0 or 1)
R: RIGHT JUSTIFY
V: value
O: ON/OFF
C: OPEN/CLOSE <<<<< Change this to "CLOSED"
U: UP/DOWN
Methinks this would make a bit more sense. My use case is a valve that is either "OPEN" or "CLOSED"
CLOSE is not quite as informative and in some cases could be construed as being "near"
Just a wee little thing... :)
The text was updated successfully, but these errors were encountered: