Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transformation] Add L/l and c transformations (LEFT/RIGHT, L/R and OPEN/CLOSED) #3094

Merged
merged 7 commits into from Jun 2, 2020

Conversation

tonhuisman
Copy link
Contributor

@tonhuisman tonhuisman commented May 29, 2020

Just a small addition of what seems to be missing but useful.
(Changed form first using R/r to L/l as R is used for right-justify)
Added c for OPEN/CLOSED in addition to C, resolves #2351

@Budman1758
Copy link

#2351

any chance of getting this into the mix? Asking for a friend.... :)

@tonhuisman tonhuisman changed the title [Transformation] Add R/r transformations (LEFT/RIGHT and L/R) [Transformation] Add L/l and c transformations (LEFT/RIGHT, L/R and OPEN/CLOSED) May 31, 2020
Copy link
Contributor

@giig1967g giig1967g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Removing the "R" formatting command is a breaking change.
I wouldn't approve it.

@tonhuisman
Copy link
Contributor Author

Removing the "R" formatting command is a breaking change.
I wouldn't approve it.

I added it wrongly in the first commit, initially missed the existing Right-align feature, so I corrected it to L/l.

@tonhuisman
Copy link
Contributor Author

any chance of getting this into the mix? Asking for a friend.... :)

I think most of your request have already been implemented (~9 months ago, according to git), so I added 'c' (OPEN/CLOSED) as a non-breaking alternative for 'C'. If you want O/C instead, you could use the 'Ln' justification for example [Plugin#State#c] for OPEN/CLOSED or [Plugin#State#c#L1] to display O/C instead, but that was already possible with the 'C' transformation 😄.

src/Misc.ino Outdated Show resolved Hide resolved
@giig1967g
Copy link
Contributor

Removing the "R" formatting command is a breaking change.
I wouldn't approve it.

I added it wrongly in the first commit, initially missed the existing Right-align feature, so I corrected it to L/l.

I understand.

@TD-er
Copy link
Member

TD-er commented Jun 1, 2020

I understand.

@giig1967g Does that mean, you now approve of this PR?

@giig1967g
Copy link
Contributor

Hi,
yes it looks ok to me.

@TD-er TD-er merged commit 268c259 into letscontrolit:mega Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small Request in Data Transformations.
4 participants