-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No DNS entries when using Ethernet #4702
Comments
What ESPEasy release are you running? |
I'm using the latest release, selfbuild:
|
Yep, looks like a copy/paste bug... Only one thing that's a bit confusing here. Since the DNS entries are shared among ETH and WiFi (really bad design decision of LWIP), I wonder how much differences it might make here between checking dns entries for ETH and WiFi. |
Made a PR for this: |
I don't have wifi here at all. Therefore, no DNS entries can be configured via Wifi DHCP. |
I understand, but what I meant was that in LWIP (the IP stack) the entry for the DNS servers for all interfaces are being shared. But anyhow, I made the changes you suggested. If you could have a look (either at the code, or the compiled GH Actions build) at my PR to see if I messed up or that it is now fixed, then I can merge it. |
[ETH] No DNS entries when using Ethernet (#4702)
1 second after receiving the DHCP data (with correct DNS entry) both DNS variables were set to 0.0.0.0. |
Yep, the DNS fields will be cleared when WiFi.mode() changes. I'm thinking about adding very strict networking modes in ESPEasy, so WiFi doesn't even need to be started when a user needs Ethernet only. Right now I try to make it as dynamic as possible, so if the Ethernet plug is removed it will start WiFi etc. But that's a major overhaul of ESPEasy code, so I'm holding that off a bit as it is a good guarantee for lots of other side issues when doing such a major change and I need to free up quite a lot of time to spend on it continuously. |
Hello,
I am using ESPEasy in conjunction with Ethernet. Wifi is not in use, there is no connection.
With the DHCP request, the DNS servers are also transmitted (visible in the log), but the variables (dns0_cache and dns1_cache) are not set and therefore 0.0.0.0. This is due to an error in "src/src/DataStructs/EthernetEventData.cpp". "WiFi" must be changed to "ETH" there.
See "git diff":
Greetings, kuppe.
The text was updated successfully, but these errors were encountered: