[BMP280] Fix regression on #636 + split overlap in code between C001 and C002 into separate function #890
Comments
|
Hmmm I think there is just too much overlap between C001 and C002. The last sentence of this paragraph suggests the order of the values should be the same for HTTP and MQTT: https://www.domoticz.com/wiki/MQTT#Domoticz_to_MQTT |
TD-er
changed the title
… to helper Both Domoticz controllers had quite some overlap in code. And where they differ, one of them was faulty and/or already fixed. Now this overlap is split into a Domoticz helper file to keep code duplication to a minimum.
|
Added a pull request #891 |
Do not store references in a Json object, but just the string :)
) * [issue #890] Split overlap for both Domoticz controllers to helper Both Domoticz controllers had quite some overlap in code. And where they differ, one of them was faulty and/or already fixed. Now this overlap is split into a Domoticz helper file to keep code duplication to a minimum. * [issue #890] Fix some wierd data corruption Do not store references in a Json object, but just the string :) * [Domoticz] Add WiFi strength and battery info
|
yeah there where indeed some strange differences. ill run the controller tests now, it will create dummy for all datatypes, so it will fully test domoticz http and mqtt. |
|
you either fixed or broke SENSOR_TYPE_TEMP_BARO. it seems your implementation has actually comments and links to the domoticz api, like it should, so i'll go with yours and fix the regression test accordingly. :) |
|
INFO:esptest:*** All tests completed *** |
See topic: http://www.letscontrolit.com/forum/viewtopic.php?f=18&t=4864
Was fixed in #636
Bug was re-introduced in: 3922827
So @psy0rz if there was a good reason for this change, please have a look at it.
Or else, I will create a PR to fix it again.
The text was updated successfully, but these errors were encountered: