New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue #890] Split overlap for both Domoticz controllers to helper #891
Conversation
… to helper Both Domoticz controllers had quite some overlap in code. And where they differ, one of them was faulty and/or already fixed. Now this overlap is split into a Domoticz helper file to keep code duplication to a minimum.
Do not store references in a Json object, but just the string :)
Nice idea, no code duplication and always fix in one place, and for domoticz only transport is different data are same. |
rssi :)
It wasn't work some time ago in domoticz
18.02.2018 2:45 PM "Gijs Noorlander" <notifications@github.com> napisał(a):
… I also sneaked in some new feature for use with Domoticz :)
[image: image]
<https://user-images.githubusercontent.com/3751318/36352511-5c5ebdf6-14ba-11e8-862a-30687701f8b8.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#891 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHOU-ww0uDMOOYrTPN2sHaztSx1qu1-ks5tWCmJgaJpZM4SJgoC>
.
|
If VCC define is set, it will also output the battery level. Might also be nice to have for net powered devices I guess to see if the power supply is sufficient. |
@TD-er Can you please explain me how to send the Battery level to domoticz as you described above? It is possible but i don't know what i have to do to enable it. Sorry |
You only have to use a firmware that has the VCC defined. |
Thanks for your reply. So I do not have to do anything else except activate VCC? No special cabling or activate a device? Thanks for your help. Sorry if I ask something stupid. |
Nope, it should be sent along with either Domoticz HTTP or Domoticz MQTT. You can test by adding a generic plugin to output vcc, just to see if it is active and usable. |
Both Domoticz controllers had quite some overlap in code.
And where they differ, one of them was faulty and/or already fixed.
Now this overlap is split into a Domoticz helper file to keep code duplication to a minimum.
See #890