Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue #890] Split overlap for both Domoticz controllers to helper #891

Merged
merged 3 commits into from Feb 18, 2018

Conversation

TD-er
Copy link
Member

@TD-er TD-er commented Feb 17, 2018

Both Domoticz controllers had quite some overlap in code.
And where they differ, one of them was faulty and/or already fixed.

Now this overlap is split into a Domoticz helper file to keep code duplication to a minimum.

See #890

… to helper

Both Domoticz controllers had quite some overlap in code.
And where they differ, one of them was faulty and/or already fixed.

Now this overlap is split into a Domoticz helper file to keep code duplication to a minimum.
@psy0rz psy0rz merged commit e51f768 into letscontrolit:v2.0 Feb 18, 2018
@uzi18
Copy link
Contributor

uzi18 commented Feb 18, 2018

Nice idea, no code duplication and always fix in one place, and for domoticz only transport is different data are same.

@TD-er TD-er deleted the bugfix/domoticz_controllers branch February 18, 2018 13:38
@TD-er
Copy link
Member Author

TD-er commented Feb 18, 2018

I also sneaked in some new feature for use with Domoticz :)

image

@uzi18
Copy link
Contributor

uzi18 commented Feb 18, 2018 via email

@TD-er
Copy link
Member Author

TD-er commented Feb 18, 2018

If VCC define is set, it will also output the battery level. Might also be nice to have for net powered devices I guess to see if the power supply is sufficient.

@jannnfe
Copy link

jannnfe commented Mar 26, 2018

@TD-er Can you please explain me how to send the Battery level to domoticz as you described above? It is possible but i don't know what i have to do to enable it. Sorry

@TD-er
Copy link
Member Author

TD-er commented Mar 26, 2018

You only have to use a firmware that has the VCC defined.
If you want to compile yourself, just define FEATURE_ADC_VCC as true

@jannnfe
Copy link

jannnfe commented Mar 26, 2018

Thanks for your reply. So I do not have to do anything else except activate VCC? No special cabling or activate a device? Thanks for your help. Sorry if I ask something stupid.

@TD-er
Copy link
Member Author

TD-er commented Mar 26, 2018

Nope, it should be sent along with either Domoticz HTTP or Domoticz MQTT.
Both include the "battery level" with each message.

You can test by adding a generic plugin to output vcc, just to see if it is active and usable.
Of use %vcc% somewhere in rules or a display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants