[Dallas] Fix Dallas 1Wire plugins on ESP32 #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the `pinMode` call on ESP SDK 2.0.3 and 2.0.4 now takes 16 usec to complete, compared to 4 msec before. The [OneWire library maintained by PaulStoffregen](https://github.com/PaulStoffregen/OneWire/blob/master/OneWire.cpp) does perform direct GPIO handling on the registers instead of searching for the pins. This is apparently working as reported [here by @Jason2866](espressif/arduino-esp32#7049 (comment)) So I replaced all time critical calls for the Dallas plugins with the macros from Paul's library.
|
|
This was referenced Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the
pinModecall on ESP SDK 2.0.3 and 2.0.4 now takes 16 usec to complete, compared to 4 msec before.The OneWire library maintained by PaulStoffregen does perform direct GPIO handling on the registers instead of searching for the pins.
This is apparently working as reported here by @Jason2866
So I replaced all time critical calls for the Dallas plugins with the macros from Paul's library.