Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send mail in advance of certificate expiration via periodic tasks #102

Closed
jsha opened this issue Apr 17, 2015 · 4 comments
Closed

Send mail in advance of certificate expiration via periodic tasks #102

jsha opened this issue Apr 17, 2015 · 4 comments
Milestone
Deployment

Comments

@jsha
Copy link
Contributor

jsha commented Apr 17, 2015

The CPS under which IdenTrust is cross-certifying us requires advance notice of certificate expiration, so our CPS also needs to include advance notice. To do this we need to implement a mailer component.
@rolandshoemaker rolandshoemaker mentioned this issue Apr 18, 2015
Merged
@jcjones
Copy link
Contributor

jcjones commented Apr 20, 2015

Merged.

@jcjones jcjones closed this as completed Apr 20, 2015
@jcjones
Copy link
Contributor

jcjones commented Apr 20, 2015

Reopening to add the send-mail template.

@jcjones jcjones reopened this Apr 20, 2015
@jcjones jcjones changed the title Implement a mailer Send mail in advance of certificate expiration via periodic tasks Apr 20, 2015
@jcjones
Copy link
Contributor

jcjones commented Apr 20, 2015

I recommend we do this functionality in a similar manner to however we choose to trigger OCSP signings. I'm currently imagining writing a separate program that, when run by cron, reads the DB and triggers emails / OCSP signings, and exits when done. And then we just run it every 5-10 minutes.

Alternatively, we can make a periodic task in the RA. But a standalone program can be easier to debug / change.

@jcjones jcjones added this to the General Availability milestone May 20, 2015
@rolandshoemaker rolandshoemaker mentioned this issue Jul 25, 2015
Merged
@jsha
Copy link
Contributor Author

jsha commented Jul 30, 2015

Fixed.

@jsha jsha closed this as completed Jul 30, 2015
bouk added a commit to bouk/boulder that referenced this issue Jan 24, 2018
@bouk
Upgrade publicsuffix-go to 7881288
2e8c656 
HEAD is now at 7881288 autopull: 2018-01-24T06:00:45Z (letsencrypt#102)
?     github.com/weppos/publicsuffix-go/cmd/load  [no test files]
=== RUN   TestPublicSuffix
--- PASS: TestPublicSuffix (0.00s)
=== RUN   TestEffectiveTLDPlusOne
--- PASS: TestEffectiveTLDPlusOne (0.00s)
PASS
ok    github.com/weppos/publicsuffix-go/net/publicsuffix  0.020s
=== RUN   TestValid
--- PASS: TestValid (0.00s)
=== RUN   TestIncludePrivate
--- PASS: TestIncludePrivate (0.00s)
=== RUN   TestIDNA
--- PASS: TestIDNA (0.00s)
=== RUN   TestPsl
--- PASS: TestPsl (0.01s)
=== RUN   TestNewListFromString
--- PASS: TestNewListFromString (0.00s)
=== RUN   TestNewListFromString_IDNAInputIsUnicode
--- PASS: TestNewListFromString_IDNAInputIsUnicode (0.00s)
=== RUN   TestNewListFromString_IDNAInputIsAscii
--- PASS: TestNewListFromString_IDNAInputIsAscii (0.00s)
=== RUN   TestNewListFromFile
--- PASS: TestNewListFromFile (0.00s)
=== RUN   TestListAddRule
--- PASS: TestListAddRule (0.00s)
=== RUN   TestListFind
--- PASS: TestListFind (0.00s)
=== RUN   TestNewRule_Normal
--- PASS: TestNewRule_Normal (0.00s)
=== RUN   TestNewRule_Wildcard
--- PASS: TestNewRule_Wildcard (0.00s)
=== RUN   TestNewRule_Exception
--- PASS: TestNewRule_Exception (0.00s)
=== RUN   TestNewRule_FromASCII
--- PASS: TestNewRule_FromASCII (0.00s)
=== RUN   TestNewRule_FromUnicode
--- PASS: TestNewRule_FromUnicode (0.00s)
=== RUN   TestNewRuleUnicode_FromASCII
--- PASS: TestNewRuleUnicode_FromASCII (0.00s)
=== RUN   TestNewRuleUnicode_FromUnicode
--- PASS: TestNewRuleUnicode_FromUnicode (0.00s)
=== RUN   TestRuleMatch
--- PASS: TestRuleMatch (0.00s)
=== RUN   TestRuleDecompose
--- PASS: TestRuleDecompose (0.00s)
=== RUN   TestLabels
--- PASS: TestLabels (0.00s)
=== RUN   TestToASCII
--- PASS: TestToASCII (0.00s)
=== RUN   TestCookieJarList
--- PASS: TestCookieJarList (0.00s)
PASS
ok    github.com/weppos/publicsuffix-go/publicsuffix  0.039s
bouk added a commit to bouk/boulder that referenced this issue Jan 24, 2018
@bouk
Upgrade publicsuffix-go to 7881288
d8b5846 
HEAD is now at 7881288 autopull: 2018-01-24T06:00:45Z (letsencrypt#102)
?     github.com/weppos/publicsuffix-go/cmd/load  [no test files]
=== RUN   TestPublicSuffix
--- PASS: TestPublicSuffix (0.00s)
=== RUN   TestEffectiveTLDPlusOne
--- PASS: TestEffectiveTLDPlusOne (0.00s)
PASS
ok    github.com/weppos/publicsuffix-go/net/publicsuffix  0.020s
=== RUN   TestValid
--- PASS: TestValid (0.00s)
=== RUN   TestIncludePrivate
--- PASS: TestIncludePrivate (0.00s)
=== RUN   TestIDNA
--- PASS: TestIDNA (0.00s)
=== RUN   TestPsl
--- PASS: TestPsl (0.01s)
=== RUN   TestNewListFromString
--- PASS: TestNewListFromString (0.00s)
=== RUN   TestNewListFromString_IDNAInputIsUnicode
--- PASS: TestNewListFromString_IDNAInputIsUnicode (0.00s)
=== RUN   TestNewListFromString_IDNAInputIsAscii
--- PASS: TestNewListFromString_IDNAInputIsAscii (0.00s)
=== RUN   TestNewListFromFile
--- PASS: TestNewListFromFile (0.00s)
=== RUN   TestListAddRule
--- PASS: TestListAddRule (0.00s)
=== RUN   TestListFind
--- PASS: TestListFind (0.00s)
=== RUN   TestNewRule_Normal
--- PASS: TestNewRule_Normal (0.00s)
=== RUN   TestNewRule_Wildcard
--- PASS: TestNewRule_Wildcard (0.00s)
=== RUN   TestNewRule_Exception
--- PASS: TestNewRule_Exception (0.00s)
=== RUN   TestNewRule_FromASCII
--- PASS: TestNewRule_FromASCII (0.00s)
=== RUN   TestNewRule_FromUnicode
--- PASS: TestNewRule_FromUnicode (0.00s)
=== RUN   TestNewRuleUnicode_FromASCII
--- PASS: TestNewRuleUnicode_FromASCII (0.00s)
=== RUN   TestNewRuleUnicode_FromUnicode
--- PASS: TestNewRuleUnicode_FromUnicode (0.00s)
=== RUN   TestRuleMatch
--- PASS: TestRuleMatch (0.00s)
=== RUN   TestRuleDecompose
--- PASS: TestRuleDecompose (0.00s)
=== RUN   TestLabels
--- PASS: TestLabels (0.00s)
=== RUN   TestToASCII
--- PASS: TestToASCII (0.00s)
=== RUN   TestCookieJarList
--- PASS: TestCookieJarList (0.00s)
PASS
ok    github.com/weppos/publicsuffix-go/publicsuffix  0.039s
jsha pushed a commit that referenced this issue Jan 24, 2018
@bouk @jsha
Upgrade publicsuffix-go to 7881288 (#3391)
308a4f4 
HEAD is now at 7881288 autopull: 2018-01-24T06:00:45Z (#102)
?     github.com/weppos/publicsuffix-go/cmd/load  [no test files]
=== RUN   TestPublicSuffix
--- PASS: TestPublicSuffix (0.00s)
=== RUN   TestEffectiveTLDPlusOne
--- PASS: TestEffectiveTLDPlusOne (0.00s)
PASS
ok    github.com/weppos/publicsuffix-go/net/publicsuffix  0.020s
=== RUN   TestValid
--- PASS: TestValid (0.00s)
=== RUN   TestIncludePrivate
--- PASS: TestIncludePrivate (0.00s)
=== RUN   TestIDNA
--- PASS: TestIDNA (0.00s)
=== RUN   TestPsl
--- PASS: TestPsl (0.01s)
=== RUN   TestNewListFromString
--- PASS: TestNewListFromString (0.00s)
=== RUN   TestNewListFromString_IDNAInputIsUnicode
--- PASS: TestNewListFromString_IDNAInputIsUnicode (0.00s)
=== RUN   TestNewListFromString_IDNAInputIsAscii
--- PASS: TestNewListFromString_IDNAInputIsAscii (0.00s)
=== RUN   TestNewListFromFile
--- PASS: TestNewListFromFile (0.00s)
=== RUN   TestListAddRule
--- PASS: TestListAddRule (0.00s)
=== RUN   TestListFind
--- PASS: TestListFind (0.00s)
=== RUN   TestNewRule_Normal
--- PASS: TestNewRule_Normal (0.00s)
=== RUN   TestNewRule_Wildcard
--- PASS: TestNewRule_Wildcard (0.00s)
=== RUN   TestNewRule_Exception
--- PASS: TestNewRule_Exception (0.00s)
=== RUN   TestNewRule_FromASCII
--- PASS: TestNewRule_FromASCII (0.00s)
=== RUN   TestNewRule_FromUnicode
--- PASS: TestNewRule_FromUnicode (0.00s)
=== RUN   TestNewRuleUnicode_FromASCII
--- PASS: TestNewRuleUnicode_FromASCII (0.00s)
=== RUN   TestNewRuleUnicode_FromUnicode
--- PASS: TestNewRuleUnicode_FromUnicode (0.00s)
=== RUN   TestRuleMatch
--- PASS: TestRuleMatch (0.00s)
=== RUN   TestRuleDecompose
--- PASS: TestRuleDecompose (0.00s)
=== RUN   TestLabels
--- PASS: TestLabels (0.00s)
=== RUN   TestToASCII
--- PASS: TestToASCII (0.00s)
=== RUN   TestCookieJarList
--- PASS: TestCookieJarList (0.00s)
PASS
ok    github.com/weppos/publicsuffix-go/publicsuffix  0.039s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Deployment
Development

No branches or pull requests
3 participants
@bdaehlie @jsha @jcjones