Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-Type restriction on http-01 is not enforced #1089

Closed
jsha opened this issue Nov 5, 2015 · 6 comments
Closed

Content-Type restriction on http-01 is not enforced #1089

jsha opened this issue Nov 5, 2015 · 6 comments

Comments

@jsha
Copy link
Contributor

jsha commented Nov 5, 2015

Per spec, the Content-Type for http-01 challenges must be either empty or text/plain. However, we do not currently enforce this in Boulder.

@hlandau
Copy link
Contributor

hlandau commented Nov 5, 2015

I do wonder if it's a good idea to enforce this, at least until ACME WG properly deliberates on the issues. See ietf-wg-acme/acme#9

@My1
Copy link

My1 commented Nov 6, 2015

I think we should not care at all. there should be done 2 checks at best for this: size (to prevent download of loverly large "misplaced" files and most obviously content, that are things that are static and cannot change without affecting the actual validation.

@SkateScout
Copy link

Maybe it would also be an good idea if the client send an Accept header with its request.

@raboof
Copy link

raboof commented Nov 17, 2015

It seems the restriction on Content-Type has been removed from the spec (ietf-wg-acme/acme#40), however it seems the private beta server does require it... should we close this issue and create a new one for lifting the restriction?

@My1
Copy link

My1 commented Nov 17, 2015

I think yes we should.

@jsha
Copy link
Contributor Author

jsha commented Jun 2, 2016

Fixed.

@jsha jsha closed this as completed Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants