Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAA records not verified #1231

Closed
AlexanderS opened this issue Dec 7, 2015 · 4 comments
Closed

CAA records not verified #1231

AlexanderS opened this issue Dec 7, 2015 · 4 comments
Assignees

Comments

@AlexanderS
Copy link

I just checked if letsencrypt.org verifies CAA Records and it seems that it does not respect it. I just got a certificate for a domain that has a CAA record, that does not allow letsencrypt.org to issue a certificate.

The requested domain is asulfrian.userpage.fu-berlin.de and this are the CAA records for fu-berlin.de:

fu-berlin.de.       86400   IN  CAA 0 issue "pki.dfn.de"
fu-berlin.de.       86400   IN  CAA 0 iodef "mailto:certificate@fu-berlin.de"

There are no CAA records for the sub domains. Reading the relevant section in rfc6844 shows clearly that this records should be the relevant ones. So I should not be able to get this certificate.

@jsha jsha added this to the Sprint 2015-12-02 milestone Dec 7, 2015
@jsha
Copy link
Contributor

jsha commented Dec 7, 2015

@rolandshoemaker, can you take a look at this?

@rolandshoemaker
Copy link
Contributor

So CAA checking is working but the code that checks it's result for an error doesn't actually do anything useful with it (i.e. making the challenge invalid) meaning that a challenge that fails CAA can still be completed, this is bad.

@rolandshoemaker
Copy link
Contributor

Further inspection shows that validateChallengeAndCAA attempts to mutate the challenge passed to it by value, failing to actually change the status.

@jsha
Copy link
Contributor

jsha commented Dec 9, 2015

Thanks for reporting! This is fixed and deployed to production. We publicly disclosed the issue here: https://groups.google.com/forum/#!topic/mozilla.dev.security.policy/_HqrifRcSYs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants