New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename RA RPC UpdateAuthorization to PerformValidation #3930
Milestone
Comments
rolandshoemaker
changed the title
Rename RA RPC UpdateAuthorization PreformValidation
Rename RA RPC UpdateAuthorization to PreformValidation
Nov 13, 2018
jsha
changed the title
Rename RA RPC UpdateAuthorization to PreformValidation
Rename RA RPC UpdateAuthorization to PerformValidation
Nov 13, 2018
Note: We may actually want to give PerformValidation a slightly different API, that doesn't include a keyAuthorization object. Then we can get rid of this comment and associated code: Lines 1473 to 1482 in 465be64
|
cpu
added a commit
that referenced
this issue
Nov 28, 2018
The existing RA `UpdateAuthorization` RPC needs replacing for two reasons: 1. The name isn't accurate - `PerformValidation` better captures the purpose of the RPC. 2. The `core.Challenge` argument is superfluous since Key Authorizations are not sent in the initiation POST from the client anymore. The corresponding unmarshal and verification is now removed. Notably this means broken clients that were POSTing the wrong thing and failing pre-validation will now likely fail post-validation. To remove `UpdateAuthorization` the new `PerformValidation` RPC is added alongside the old one. WFE and WFE2 are updated to use the new RPC when the perform validation feature flag is enabled. We can remove `UpdateAuthorization` and its associated wrappers once all WFE instances have been updated. Resolves #3930
rolandshoemaker
pushed a commit
that referenced
this issue
Jan 8, 2019
Staging and prod both deployed the PerformValidationRPC feature flag. All running WFE/WFE2 instances are using the more accurately named PerformValidation RPC and we can strip out the old UpdateAuthorization bits. The feature flag for PerformValidationRPC remains until we clean up the staging/prod configs. Resolves #3947 and completes the last of #3930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current name is rather misleading.
The text was updated successfully, but these errors were encountered: