Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry-After on NewOrder #4104

Closed
alexzorin opened this issue Mar 8, 2019 · 4 comments
Closed

Retry-After on NewOrder #4104

alexzorin opened this issue Mar 8, 2019 · 4 comments

Comments

@alexzorin
Copy link
Contributor

With #2800 and #4074 closed, is there anything more needed to provide rate limit info in rateLimited responses - as Retry-After and maybe also problem details?

As a result of #2800, users are somewhat losing the ability to guesstimate the window, since the 'renewal bit' doesn't really exist in CT logs, making the query a hog.

Would be super handy for both humans and ACME clients!

@jsha
Copy link
Contributor

jsha commented Mar 8, 2019

Good idea. I think it may be time to bump up the priority on setting Retry-After headers in various places, and NewOrder seems like a good place to start.

@daramousk
Copy link

Hello Jacob and Alex,

Sorry to hijack this, but I did not want to create a new ticket for just a question.

On https://tools.ietf.org/html/rfc8555#section-8.2 the Retry-After header on the challenge response is marked as a must.

Q: Is there a plan on implementing this? Is there already a PR we can review? I am asking this because I need this and I was thinking if I should write it and contribute back. But if you already have something working I could contribute there.

Thanks for your time.

@rolandshoemaker
Copy link
Contributor

The retry-after header is only required on challenge validation if the server supports challenge retries, which boulder does not. Note this ticket is about retry-after on order generation which is related to rate limits.

@aarongable
Copy link
Contributor

The NewOrder endpoint now has a Retry-After header: #6256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants