Check for RNG failures #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,7 +72,12 @@ func B64dec(x string) ([]byte, error) { | |||
|
|
|||
| func RandomString(byteLength int) string { | |||
| b := make([]byte, byteLength) | |||
| _, _ = rand.Read(b) // NOTE: Ignoring errors | |||
| _, err := io.ReadFull(rand.Reader, b) // NOTE: Ignoring errors | |||
There was a problem hiding this comment.
Remove "ignoring errors" comment
|
I'm good with this. I'll rebase the changes and commit after #135. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #51. It depends on #135.
It also includes a basic log.EmergencyExit() function to call in case of catastrophic errors, though the corresponding piece of ActivityMonitor still needs to beimplemented.
I haven't yet learned a way to fake rand.Reader returning fewer than 32 bytes in the test case, or to test the resulting os.Exit(13) that we expect...