Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement user-facing revocation. #147

Merged
merged 6 commits into from
May 15, 2015
Merged

Implement user-facing revocation. #147

merged 6 commits into from
May 15, 2015

Conversation

jsha
Copy link
Contributor

@jsha jsha commented May 3, 2015

Note that this differs from the spec a bit. I moved the serial number into the POST body from the URL, because it should be integrity-protected by the JWS signature.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.68%) to 39.96% when pulling d860ae7 on revocation-wfe into c4497ac on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.88%) to 46.27% when pulling e997f00 on revocation-wfe into f6c7b49 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.86%) to 46.29% when pulling 2dec9f2 on revocation-wfe into f6c7b49 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.86%) to 46.29% when pulling eeeab2a on revocation-wfe into f6c7b49 on master.

@kuba
Copy link
Contributor

kuba commented May 12, 2015

Note to self: client will, obviously, have to be updated. However, we don't implement revocation at the moment anyway, so nothing would break if demo were to be updated.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.06%) to 46.93% when pulling 048f10f on revocation-wfe into ec88d9d on master.

@jsha
Copy link
Contributor Author

jsha commented May 14, 2015

Rebased against latest master, ready for review. Also the spec fix is now merged.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.87%) to 43.89% when pulling f8d54a7 on revocation-wfe into a20f145 on master.

@jcjones
Copy link
Contributor

jcjones commented May 15, 2015

This looks good to me. I am merging.

jcjones added a commit that referenced this pull request May 15, 2015
Implement user-facing revocation.
@jcjones jcjones merged commit 2ba4698 into master May 15, 2015
@jsha jsha deleted the revocation-wfe branch May 19, 2015 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants