Check account and cert keys for strength #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rsaKey, ok := key.(*rsa.PublicKey) | ||
| if !ok { | ||
| if jwk, ok := key.(jose.JsonWebKey); ok && jwk.Rsa != nil { | ||
| rsaKey = jwk.Rsa |
There was a problem hiding this comment.
I'd prefer to go ahead and call a new method like GoodKeyRsa() here and move the below out, and make a stub for GoodKeyEcc() that returns err.
|
I'm good with this merging as is if you open Issues for the two comments above, or resolve them before merging. Overall, looks good to me! |
jsha
force-pushed
the
goodkey
branch
2 times, most recently
from
ea457f7
to
0882e34
Compare
Conflicts: ca/certificate-authority.go core/good_key.go core/good_key_test.go
|
Done. |
jcjones
added a commit
that referenced
this pull request
May 11, 2015
Check account and cert keys for strength
|
All looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
Fixes #116