Reduce use of naked returns #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,13 +62,15 @@ type CertificateAuthorityImpl struct { | |||
| // using CFSSL's authenticated signature scheme. A CA created in this way | |||
| // issues for a single profile on the remote signer, which is indicated | |||
| // by name in this constructor. | |||
| func NewCertificateAuthorityImpl(cadb core.CertificateAuthorityDatabase, config Config) (ca *CertificateAuthorityImpl, err error) { | |||
| func NewCertificateAuthorityImpl(cadb core.CertificateAuthorityDatabase, config Config) (*CertificateAuthorityImpl, error) { | |||
| var ca *CertificateAuthorityImpl | |||
There was a problem hiding this comment.
I think it's okay, even if you're using clothed returns, to declare the variables in the return statement of the function. You would just name them explicitly in the return. But I'm not 100% on go standard style, so feel free to correct me.
There was a problem hiding this comment.
Also, it seems like this is the only spot where this comment is relevant, so I'm not going to worry about it.
Thanks for this change, nice improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
or _The great enrobing!_
Fixes for #152 as well as various
returnrelated cleanups, I've left naked returns on most smaller functions (~ <30 lines) where readability doesn't really suffer too much.