Temporarily allow fetching of expired authzs. #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1244,12 +1244,6 @@ func (wfe *WebFrontEndImpl) Authorization(ctx context.Context, logEvent *web.Req | |||
| logEvent.Extra["Identifier"] = authz.Identifier | |||
| logEvent.Extra["AuthorizationStatus"] = authz.Status | |||
|
|
|||
| // After expiring, authorizations are inaccessible | |||
There was a problem hiding this comment.
Given we plan to turn this back on could you just comment it out with a TODO and open a issue to turn the behavior back on.
There was a problem hiding this comment.
I don't like to leave commented out code checked in, but I've filed an issue to restore the 404s: #3781
cpu
suggested changes
Jun 26, 2018
There was a problem hiding this comment.
There's an integration test failing in CI that needs to be fixed up in this branch :
Traceback (most recent call last):
File "test/integration-test.py", line 700, in <module>
main()
File "test/integration-test.py", line 633, in main
run_chisel(args.test_case_filter)
File "test/integration-test.py", line 657, in run_chisel
value()
File "test/integration-test.py", line 499, in test_expired_authzs_404
response.status_code)
Exception: ('Unexpected response for expired authz: ', 200)
Closed
cpu
suggested changes
Jun 27, 2018
There was a problem hiding this comment.
Still failing in CI :-(
Traceback (most recent call last):
File "test/integration-test.py", line 681, in <module>
main()
File "test/integration-test.py", line 598, in main
setup_seventy_days_ago()
File "test/integration-test.py", line 56, in setup_seventy_days_ago
_, old_authzs = auth_and_issue([random_domain()])
TypeError: 'NoneType' object is not iterable
jsha
force-pushed
the
get-expired-authorizations
branch
from
b0c381f
to
b6ba19f
Compare
rolandshoemaker
approved these changes
Jun 29, 2018
cpu
added a commit
that referenced
this pull request
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows deactivating expired authzs, which is fine.
Fixes #3777