checkocsp: verify validity period of signing certificate #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // certificate signed it, and that that certificate is currently valid. | ||
| func checkSignature(resp *ocsp.Response, issuer *x509.Certificate) error { | ||
| var ocspSigner = issuer | ||
| if delegatedSigner := resp.Certificate; delegatedSigner != nil { |
There was a problem hiding this comment.
x/crypto/ocsp already does this signature checking for us, I think all we need to do is check that the certificate is still valid.
test/ocsp/helper/helper.go
Outdated
| @@ -222,5 +266,10 @@ func parseAndPrint(respBytes []byte, cert, issuer *x509.Certificate, expectStatu | |||
| fmt.Printf(" RevocationReason %d\n", resp.RevocationReason) | |||
| fmt.Printf(" SignatureAlgorithm %s\n", resp.SignatureAlgorithm) | |||
| fmt.Printf(" Extensions %#v\n", resp.Extensions) | |||
| fmt.Printf(" Certificate:\n") | |||
There was a problem hiding this comment.
This will panic if we don't get a bundled certificate.
test/ocsp/helper/helper.go
Outdated
| if resp.Certificate == nil { | ||
| fmt.Printf(" Certificate: nil\n") | ||
| } else { | ||
| fmt.Printf(" Certificate:\n") |
There was a problem hiding this comment.
extremely nit: Printf with no formatting directive.
There was a problem hiding this comment.
somewhat surprised we don;t get a vet error for this.
There was a problem hiding this comment.
go vet actually does spot this, but we don't run go vet in Travis because it's too noisy, and it's explicitly documented as something not recommended for CI.
But thanks for the suggestion on running it- I actually found a bug on another line.
rolandshoemaker
approved these changes
Jun 8, 2020
jsha
changed the title
jsha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.