Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch docker base image from buster-scm to focal-scm #5287

Merged
merged 4 commits into from
Feb 22, 2021
Merged

Switch docker base image from buster-scm to focal-scm #5287

merged 4 commits into from
Feb 22, 2021

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Feb 12, 2021 •
edited

  • Switch docker base image frombuster-scm to focal-scm
  • Add dockerfile lines to correct /etc/rsyslog.conf settings

Fixes #5295

@beautifulentropy beautifulentropy changed the title CI test using arm64-gravitron instances CI Experiments Feb 13, 2021
@jsha
Copy link
Contributor

jsha commented Feb 17, 2021

Can you update the PR description and take this out of draft? Sounds like you found that moving to focal is a straightforward speed win.

@beautifulentropy
Decrease CI Runtime
44d42ce 
- Use ubuntu focal-scm as docker base
- Echo test stage on failure
@beautifulentropy beautifulentropy changed the title CI Experiments Move docker base to focal-scm Feb 17, 2021
@beautifulentropy beautifulentropy marked this pull request as ready for review February 18, 2021 00:57
@beautifulentropy beautifulentropy requested a review from a team as a code owner February 18, 2021 00:57
@beautifulentropy beautifulentropy changed the title Move docker base to focal-scm Move docker base image from buster-scm to focal-scm Feb 18, 2021
aarongable
aarongable requested changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break the test.sh changes out into a separate PR. They look great, but don't seem to be strictly related to updating the base image.

test/boulder-tools/Dockerfile Show resolved Hide resolved
@beautifulentropy beautifulentropy changed the title Move docker base image from buster-scm to focal-scm Switch docker base image from buster-scm to focal-scm Feb 19, 2021
@jsha jsha merged commit 7cbfe94 into main Feb 22, 2021
@jsha jsha deleted the dizzy-tests branch February 22, 2021 18:33
@jsha jsha mentioned this pull request Apr 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsha jsha jsha approved these changes

@aarongable aarongable aarongable approved these changes

@andygabby andygabby Awaiting requested review from andygabby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch docker base image from buster-scm to focal-scm
3 participants
@beautifulentropy @jsha @aarongable