Add gRPC MaxConnectionAge config. #5311
Conversation
This allows servers to tell clients to go away after some period of time, which triggers the clients to re-resolve DNS.
|
Closing and reopening to try and trigger GitHub CI. |
|
Adding an approval, because the change looks good, but a question to consider. Do we want to combine this with setting the MaxConnectionAgeGrace flag too? If I am reading it right, it appears to be an additive time after MaxConnectionAge where the connection will be forcibly closed. This would ensure that nothing could keep an open connection that hasn't read the new DNS record. It seems like something we might want to tune. Here is a reference to tuning it if you are using the keepalive to periodically resolve DNS. |
Co-authored-by: Samantha <hello@entropy.cat>
|
I think we don't really need a sub-infinite grace period, because all of our requests have fairly short timeouts (sub-5m), and we trust the timeout mechanism. But if I turn out to be wrong, we can always add that later! |
This allows servers to tell clients to go away after some period of time, which triggers the clients to re-resolve DNS. Per grpc/grpc#12295, this is the preferred way to do this. Related: #5307.
This allows servers to tell clients to go away after some period of time, which triggers the clients to re-resolve DNS.
Per grpc/grpc#12295, this is the preferred way to do this.
Related: #5307.