Remove publisher gRPC wrapper #5327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete the PublisherClientWrapper and PublisherServerWrapper. Update various structs and functions to expect a pubpb.PublisherClient instead of a core.Publisher; these two interfaces differ only in that the auto-generated PublisherClient takes a variadic CallOptions parameter. Update all mock publishers in tests to match the new interface. Finally, delete the now-unused core.Publisher interface and some already-unused mock-generating code. This deletes a single sanity check (for a nil SCT even when there is a nil error), but that check was redundant with an identical check in the only extant client code in ctpolicy.go.
jsha
approved these changes
Mar 11, 2021
andygabby
approved these changes
Mar 11, 2021
beautifulentropy
pushed a commit
that referenced
this pull request
Mar 12, 2021
Delete the PublisherClientWrapper and PublisherServerWrapper. Update various structs and functions to expect a pubpb.PublisherClient instead of a core.Publisher; these two interfaces differ only in that the auto-generated PublisherClient takes a variadic CallOptions parameter. Update all mock publishers in tests to match the new interface. Finally, delete the now-unused core.Publisher interface and some already-unused mock-generating code. This deletes a single sanity check (for a nil SCT even when there is a nil error), but that check was redundant with an identical check in the only extant client code in ctpolicy.go. Fixes #5323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the PublisherClientWrapper and PublisherServerWrapper. Update
various structs and functions to expect a pubpb.PublisherClient instead
of a core.Publisher; these two interfaces differ only in that the
auto-generated PublisherClient takes a variadic CallOptions parameter.
Update all mock publishers in tests to match the new interface. Finally,
delete the now-unused core.Publisher interface and some already-unused
mock-generating code.
This deletes a single sanity check (for a nil SCT even when there is a
nil error), but that check was redundant with an identical check in the
only extant client code in ctpolicy.go.
Fixes #5323