Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate embedded DBConfig struct #5348

Merged
merged 1 commit into from Mar 18, 2021
Merged

Deprecate embedded DBConfig struct #5348

merged 1 commit into from Mar 18, 2021

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Mar 18, 2021 •
edited

Default boulder code paths to exclusively use the db config key

Fixes #5338

@beautifulentropy beautifulentropy marked this pull request as ready for review March 18, 2021 20:46
@beautifulentropy beautifulentropy requested a review from a team as a code owner March 18, 2021 20:46
@beautifulentropy beautifulentropy changed the title Remove dbconfig migration deployability code Deprecate embedded DBConfig struct Mar 18, 2021
@beautifulentropy beautifulentropy mentioned this pull request Mar 18, 2021
Merged
@jsha jsha merged commit 5a92926 into main Mar 18, 2021
@jsha jsha deleted the dbconfig-part-two branch March 18, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsha jsha jsha approved these changes

@aarongable aarongable aarongable approved these changes

@andygabby andygabby Awaiting requested review from andygabby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate embedded DBConfig struct
3 participants
@beautifulentropy @jsha @aarongable