Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on Go 1.17.5 #5845

Merged
merged 6 commits into from
Dec 10, 2021
Merged

Run tests on Go 1.17.5 #5845

merged 6 commits into from
Dec 10, 2021

Conversation

aarongable
Copy link
Contributor

@aarongable aarongable commented Dec 9, 2021

Build a new docker container for today's Go 1.17.5 security release,
which includes a fix for the net/http package. Update our CI to run
tests on both our current and the new go versions.

@aarongable aarongable requested a review from a team as a code owner December 9, 2021 18:50
@aarongable
Copy link
Contributor Author

oh no I probably messed something up with the new go installs; looking

@beautifulentropy
Copy link
Member

oh no I probably messed something up with the new go installs; looking

Yeah, I think go 1.17 had included backward compat for go get but on new versions it won't just warn you, it simply won't do the install.

@aarongable
Copy link
Contributor Author

I've separated the go get --> go install change into #5846 to keep this single-purpose. I'm also moving it back to Draft because I can't actually run tag_and_upload right now because the new version of it doesn't work with rootless docker.

@aarongable aarongable marked this pull request as draft December 10, 2021 02:25
@aarongable aarongable marked this pull request as ready for review December 10, 2021 22:40
@aarongable aarongable merged commit c88640c into main Dec 10, 2021
@aarongable aarongable deleted the go-1.17.5 branch December 10, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants