Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove debug log to not depend on the boulder/log package #6029

Merged
merged 1 commit into from Mar 31, 2022
Merged

remove debug log to not depend on the boulder/log package #6029

merged 1 commit into from Mar 31, 2022

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Mar 31, 2022

  • remove debug log to not depend on the boulder/log package

based on comment #6021 (comment)

cc @jsha

Thanks for the guidance!

@cpanato
remove debug log to not depend on the boulder/log package
d354056 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato requested a review from a team as a code owner March 31, 2022 09:13
@cpanato cpanato requested a review from aarongable March 31, 2022 09:13
This was referenced Mar 31, 2022
Closed
Merged
aarongable
aarongable approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

jsha
jsha approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsha jsha merged commit b23ab96 into letsencrypt:main Mar 31, 2022
@haydentherapper haydentherapper mentioned this pull request Mar 31, 2022
Merged
@cpanato cpanato deleted the core-remove-log branch April 1, 2022 06:44
@cpanato cpanato mentioned this pull request Apr 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsha jsha jsha approved these changes

@aarongable aarongable aarongable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpanato @jsha @aarongable