Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch cert-checker hard-coded log levels and handle nil mariadb response #6066

Merged
merged 9 commits into from
May 2, 2022
Merged

Patch cert-checker hard-coded log levels and handle nil mariadb response #6066

merged 9 commits into from
May 2, 2022

Conversation

danjeffery
Copy link
Contributor

@danjeffery danjeffery commented Apr 27, 2022 •
edited by aarongable
Loading

  • Fix cert-checker to use the syslog and stdout logging facilities it
    reads from the config file instead of having them hard-coded to zero.
  • Fix cert-checker to handle a nil response from mariadb if no records
    are found.
  • Fix comment in log.go to correctly describe when the initialize function
    and therefore default values would be used.

Fixes #6067

@danjeffery
Patch cert-checker
fbe80dd 
- Fix cert-checker to use the syslog and stdout logging facilities it
reads from the config file instead of having them hard-coded to zero.
- Fix cert-checker to handle a nil response from mariadb if no records
are found.
- Fix comment in log.go to correctly describe when the initialize function
and therefore default values would be used.
@danjeffery danjeffery requested a review from a team as a code owner April 27, 2022 16:54
@danjeffery danjeffery mentioned this pull request Apr 27, 2022
Closed
@danjeffery danjeffery changed the title Patch cert-checker Patch cert-checker hard-coded log levels and handle nil mariadb response Apr 27, 2022
aarongable
aarongable previously approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two optional nits

cmd/cert-checker/main_test.go Outdated Show resolved Hide resolved
cmd/cert-checker/main_test.go Outdated Show resolved Hide resolved
@aarongable aarongable requested review from beautifulentropy and removed request for andygabby April 27, 2022 23:56
@danjeffery @aarongable
Update cmd/cert-checker/main_test.go
f428cf4 
Co-authored-by: Aaron Gable <aaron@aarongable.com>
@danjeffery
Copy link
Contributor Author

Great suggestions, thanks.

aarongable
aarongable previously approved these changes Apr 28, 2022
View reviewed changes
beautifulentropy
beautifulentropy previously requested changes Apr 29, 2022
View reviewed changes
Copy link
Member

@beautifulentropy beautifulentropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just some small formatting and comment nits. I also believe that your tests are currently failing.

log/log.go Outdated Show resolved Hide resolved
cmd/cert-checker/main.go Outdated Show resolved Hide resolved
cmd/cert-checker/main_test.go Outdated Show resolved Hide resolved
cmd/cert-checker/main_test.go Outdated Show resolved Hide resolved
cmd/cert-checker/main_test.go Outdated Show resolved Hide resolved
cmd/cert-checker/main.go Outdated Show resolved Hide resolved
@danjeffery @beautifulentropy
Update log/log.go
74315b4 
Co-authored-by: Samantha <hello@entropy.cat>
@danjeffery
Copy link
Contributor Author

Thanks for the comments feedback. I think I've addressed it all.
There are definitely failing tests, but none of the failures seem to have anything to do with the code I've touched so I hadn't attempted to troubleshoot them. The same failures occur when running the unit tests against main.

@aarongable
Copy link
Contributor

Yep I've filed issues for the unit test flakes. Will try to get those fixed ASAP, even if it means reverting recent changes.

@aarongable aarongable dismissed beautifulentropy’s stale review May 2, 2022 20:27

OOO, comments addressed

@aarongable aarongable merged commit a2ff222 into letsencrypt:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongable aarongable aarongable approved these changes

@beautifulentropy beautifulentropy Awaiting requested review from beautifulentropy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cert-checker crash on empty DB query
3 participants
@danjeffery @aarongable @beautifulentropy