Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cert-checker in config-next integration tests #7440

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

aarongable
Copy link
Contributor

Cert checker has been failing in config-next because the "CertCheckerRequiresCorrespondence" flag is enabled, but no permissions were granted on the precertificates table. While this did cause it to log profusively, this did not cause the tests to fail because integration-test.py simply executes cert-checker without caring about its exit code.

@aarongable aarongable requested a review from a team as a code owner April 18, 2024 05:14
Copy link
Contributor

@aarongable, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

@aarongable
Copy link
Contributor Author

This is test-only, no ticket necessary.

For context, here's how cert-checker is run in the integration tests:

def run_cert_checker():
run(["./bin/boulder", "cert-checker", "-config", "%s/cert-checker.json" % config_dir])

@pgporada pgporada requested a review from jsha April 18, 2024 15:47
@aarongable
Copy link
Contributor Author

Test-only, merging on one review.

@aarongable aarongable merged commit 13172ac into main Apr 18, 2024
15 checks passed
@aarongable aarongable deleted the fix-cert-checker-ci branch April 18, 2024 16:40
vbaranovskiy-plesk pushed a commit to plesk/boulder that referenced this pull request May 30, 2024
Cert checker has been failing in config-next because the
"CertCheckerRequiresCorrespondence" flag is enabled, but no permissions
were granted on the precertificates table. While this did cause it to
log profusively, this did not cause the tests to fail because
integration-test.py simply executes cert-checker without caring about
its exit code.
vbaranovskiy-plesk pushed a commit to plesk/boulder that referenced this pull request May 30, 2024
Cert checker has been failing in config-next because the
"CertCheckerRequiresCorrespondence" flag is enabled, but no permissions
were granted on the precertificates table. While this did cause it to
log profusively, this did not cause the tests to fail because
integration-test.py simply executes cert-checker without caring about
its exit code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants