VA: put most recent, not original, IP in error messages #7468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
approved these changes
May 2, 2024
aarongable
requested review from
a team and
beautifulentropy
and removed request for
a team
beautifulentropy
approved these changes
May 3, 2024
vbaranovskiy-plesk
pushed a commit
to plesk/boulder
that referenced
this pull request
May 30, 2024
…7468) When we present error messages containing IP addresses to end users, sometimes we're presenting the IP at which we began a chain of redirects, but not presenting the IP at which the final redirect was located. This can make it difficult for client operators to identify exactly which server in their infrastructure is misbehaving. Change our IP error messages to reference the most-recently-tried address from the set of all validation records, rather than the address which started the current (potential) redirect chain. Fixes letsencrypt#7347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we present error messages containing IP addresses to end users, sometimes we're presenting the IP at which we began a chain of redirects, but not presenting the IP at which the final redirect was located. This can make it difficult for client operators to identify exactly which server in their infrastructure is misbehaving.
Change our IP error messages to reference the most-recently-tried address from the set of all validation records, rather than the address which started the current (potential) redirect chain.
Fixes #7347