WFE: Add some basic illegal domain name handling. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ports some of Boulder's more complex `policy.WillingToIssue` logic. Prior to this commit Pebble would create new order objects with clearly illegal DNS identifiers. This commit improves this situation by rejecting the most egregious illegal domains. Now rejected are: 1) empty domains 2) too long domains 3) domains with illegal characters 4) domains that are an IP address 5) domains that end in a '.' Still left unaddressed are: 1) fine grained evaluation of individual DNS labels (length, content, etc) 2) checking for a known ICANN suffix with the public-suffix list 3) any kind of hostname policy blocklist checking 4) any kind of IDN or encoding checking I think this strikes a good balance of catching low hanging fruit and not overly complicating Pebble. Along the way I deleted the account argument to `verifyOrder`. It was not being referenced except to check it wasn't nil.
jsha
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports some of Boulder's more complex
policy.WillingToIssuelogic. Prior to this commit Pebble would create new order objects with clearly illegal DNS identifiers. This commit improves this situation byrejecting the most egregious illegal domains.
Now rejected are:
Still left unaddressed are:
I think this strikes a good balance of catching low hanging fruit and not overly complicating Pebble.
Along the way I deleted the account argument to
verifyOrder. It was not being referenced except to check it wasn't nil.Resolves #121