Wildcard orders being rejected with "illegal character: '*'" error

[rmbolger]

I believe PR #122 accidentally introduced a bug that now rejects wildcard domain identifiers in new order requests.

pebble/wfe/wfe.go

Lines 767 to 772 in 2462e27

	// isDNSCharacter is ported from Boulder's `policy/pa.go` implementation.
	func isDNSCharacter(ch byte) bool {
	return ('a' <= ch && ch <= 'z') ||
	('A' <= ch && ch <= 'Z') ||
	('0' <= ch && ch <= '9') ||
	ch == '.' || ch == '-'

pebble/wfe/wfe.go

Lines 811 to 815 in 2462e27

	for _, ch := range []byte(rawDomain) {
	if !isDNSCharacter(ch) {
	return acme.MalformedProblem(fmt.Sprintf(
	"Order included DNS identifier with a value containing an illegal character: %q",
	ch))

Should the * character be added to the allowed list in isDNSCharacter?

[cpu]

Good catch, thanks! I based #122 on Boulder's PA.WillingToIssue but totally forgot that wildcard support is predicated on PA.WillingToIssueWildcard and should have been considered for Pebble.

[cpu]

Fixed in master with c5ebb21. Thanks @rmbolger !