core: remove Account ID field from JSON responses. #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `core.Account` type has an `ID` string field that is used to internally track the ID of the ACME account. It should not be returned in JSON `Account` resource responses, it's not an RFC 8555 specified field. Boulder may return a similar field but that's a convenience and not a protocol feature. The RFC 8555 method of learning the account's ID is from the `Location` header.
jsha
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
core.Accounttype has anIDstring field that is used to internally track the ID of the ACME account. It should not be returned in JSONAccountresource responses, it's not an RFC 8555 specified field. Boulder may return a similar field but that's a convenience and not a protocol feature. The RFC 8555 method of learning the account's ID is from theLocationheader. Removing this field from the PebbleAccountJSON responses will help ensure that ACME clients do the right thing.