Show only ACMEv2 clients on client-options. #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that account creation is disabled, it doesn't make sense to recommend a v1 client to any new users. Tidied up the description of the Python acme module. Removed the note to developers about submitting edits for upgrades to v2. We have a footer with instructions on adding clients. I added an ACMEv2 mention there.
Since all displayed comments now support ACMEv2, it would be confusing for only some clients to mention it.
tdelmas
approved these changes
Nov 14, 2019
pgporada
approved these changes
Nov 14, 2019
This was referenced Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that account creation is disabled, it doesn't make sense to
recommend a v1 client to any new users.
Tidied up the description of the Python acme module.
Removed the note to developers about submitting edits for upgrades to
v2. We have a footer with instructions on adding clients. I added an
ACMEv2 mention there.
Removed "v2" language from client comments. Since all displayed
comments now support ACMEv2, it would be confusing for only
some clients to mention it.
Add a heading section addressing ACMEv1 deprecation.