-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
segmentation fault if batch has nully key or value #19
Comments
I was just working with this :) Please assign yourself to an issue before you start working. That goes for myself too as well! |
LOL, the fix was practically identical :) I also added a more generic macro and had the previous index-based version call the new one. I'm happy with this fix. |
Oh! Sorry! It's great to have other people getting dirty in the C++ btw. |
The macros are a pain to debug though. |
I know... if you want to try an alternative approach then be my guest. I hate C macros but I also hate needless duplication. |
I was working a a PR to fix this in levelup, when I realized this was actually a leveldown problem.
The text was updated successfully, but these errors were encountered: