Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segmentation fault if batch has nully key or value #19

Closed
dominictarr opened this issue Mar 9, 2013 · 5 comments
Closed

segmentation fault if batch has nully key or value #19

dominictarr opened this issue Mar 9, 2013 · 5 comments
Labels
bug Something isn't working

Comments

@dominictarr
Copy link
Contributor

I was working a a PR to fix this in levelup, when I realized this was actually a leveldown problem.

@ralphtheninja
Copy link
Member

I was just working with this :) Please assign yourself to an issue before you start working. That goes for myself too as well!

@ralphtheninja
Copy link
Member

LOL, the fix was practically identical :) I also added a more generic macro and had the previous index-based version call the new one. I'm happy with this fix.

@rvagg
Copy link
Member

rvagg commented Mar 9, 2013

Oh! Sorry! It's great to have other people getting dirty in the C++ btw.

@ralphtheninja
Copy link
Member

The macros are a pain to debug though.

@rvagg
Copy link
Member

rvagg commented Mar 9, 2013

I know... if you want to try an alternative approach then be my guest. I hate C macros but I also hate needless duplication.

@rvagg rvagg closed this as completed in cffda8e Mar 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants