Add nyc and coveralls #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
approved these changes
Jul 15, 2018
vweevers
reviewed
Jul 15, 2018
| @@ -15,3 +15,4 @@ README | |||
| INSTALL | |||
| NEWS | |||
| AUTHORS | |||
| .nyc_output/ | |||
There was a problem hiding this comment.
I compared with level-ws and I can't figure out why irish-pub doesn't mention the .nyc_output/*.json files because they aren't in .npmignore. So for leveldown I had to add .nyc_output to .npmignore.
There was a problem hiding this comment.
If there's no .npmignore then npm looks at .gitignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.