Finalize next #511
Merged
Finalize next #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Location was removed from abstract-leveldown * handle location in LevelDOWN constructor * pass a factory function to abstract tests * use tempy and remove cleanup code * Add type check for location in constructor
* Target abstract-leveldown#ffba12f * Use single test function from abstract-leveldown * Target abstract-leveldown#d7411bb * Options is actually now passed as options from abstract-leveldown and not a function
With undefined behavior for nullish targets (range options and seek targets). Previously, nullish range options were ignored and seek(null) and seek(undefined) would throw an error. Now they translate to String(null) and String(undefined). This change makes it explicit that leveldown only supports buffers and strings. Nullish targets do have a meaning in the ecosystem; that meaning should be given at a higher level like encoding-down. In other words, it isn't leveldown's concern anymore.
Update next to latest abstract-leveldown
Migrate seek tests to abstract-leveldown
| run() | ||
| }) | ||
| db = testCommon.factory() | ||
| db.open({ xcacheSize: 0, xmaxOpenFiles: 10 }, function () { |
There was a problem hiding this comment.
Are these really real properties? I know it's irrelevant to this PR, just curious.
There was a problem hiding this comment.
Let's find out. I'm opening an issue.
ralphtheninja
approved these changes
Oct 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #510. I started this
finalize-nextbranch thinking there was more work but we're already done :) So this PR targets master directly. The last two commits are new.After this we can update the changelog and upgrade guide on master (#512).