Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use column names/labels as CSS classes #11

Closed
3noch opened this issue Aug 16, 2016 · 2 comments
Closed

Don't use column names/labels as CSS classes #11

3noch opened this issue Aug 16, 2016 · 2 comments
Labels

Comments

@3noch
Copy link

3noch commented Aug 16, 2016

Nick and I spent almost an hour tracking this one down: One of my grid columns was coming from our LookupMixin which has a column named label. I was showing that label on webgrid and you could filter it. But webgrid used the column name label as the class on the filter HTML. Bootstrap also has a label class. So you can imagine the styling was all wrong.

Basically this was an extremely surprising bug and we really should not be doing this. We should derive some highly unlikely name for our CSS classes instead of copying directly from the column names.

@3noch 3noch added the bug label Aug 16, 2016
@guruofgentoo
Copy link
Member

It appears this has long since been resolved.

@3noch
Copy link
Author

3noch commented Jun 18, 2019

Glad to hear it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants