Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to set a column_group on a column #32

Closed
2 tasks
RyanPnayR opened this issue Feb 5, 2018 · 0 comments · Fixed by #74
Closed
2 tasks

Add the ability to set a column_group on a column #32

RyanPnayR opened this issue Feb 5, 2018 · 0 comments · Fixed by #74
Assignees

Comments

@RyanPnayR
Copy link

  • Update renderer
  • Get columns set up

Slack reference

class SentTimeGroup(ColumnGroup):
	label = 'Sent Time (s)
class RacesGrid(Grid):
    RaceIdColumn('Id', ents.Race.id)
    Column('Max', some_aggregate, filters.NumericFilter, group=SentTimeGroup)

Randy Syring [1:56 PM]
There is a lot of wasted space in the header cells b/c of the need to repeate "Sent Time (s)" and "Receive Time (s)" in columns.
What if we created the ability to set a column_group on a column so that the grid looked like: example

Matt Lewellyn [2:00 PM]
adding that to webgrid or rolling it into your project would be fairly trivial, I think

Bill Adams [2:01 PM]
That would require updates to the renderers. I'm not sure how difficult it would be to get that property passed through on the column to the renderer
It could possibly be done without any updates to webgrid

Randy Syring [2:02 PM]
My thinking was to roll it into webgrid.

Matt Lewellyn [2:03 PM]
I agree it might be useful. The renderer piece of it should be the trivial part. Could be more of a task to get the columns set up, with the way webgrid creates those for the grid instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants