Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: refactor renderer connections #39

Open
guruofgentoo opened this issue May 10, 2018 · 0 comments
Open

BREAKING: refactor renderer connections #39

guruofgentoo opened this issue May 10, 2018 · 0 comments

Comments

@guruofgentoo
Copy link
Member

Currently, with the way Excel exports work, format-specific information has a lot of fingers reaching into the main grid code.

  • there are methods in the framework plugins and the HTML renderer directly named for an xls export
  • columns have xls-specific init parameters and methods
  • Grid.set_renderers sets direct attributes for the renderers (e.g. Grid.html, Grid.xls)

This needs to get refactored. When #21 happens, the first point above should be addressed in a non-breaking manner. The other items will break compatibility and should be reserved for a more major revision:

  • Grid should namespace renderer attributes set in set_renderers
  • the xls-specific methods in columns will need to be thought through a bit more. Renderer-specific operations should be handled within the renderer, which may mean passing an inner class of the renderer to the column to keep track of those things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant