Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some icons not available #89

Closed
limitedmage opened this issue Oct 13, 2021 · 4 comments
Closed

Some icons not available #89

limitedmage opened this issue Oct 13, 2021 · 4 comments

Comments

@limitedmage
Copy link

Some icons, such as weather-cloudy-clock, are not available with this library. Maybe the library is outdated?
@limitedmage limitedmage mentioned this issue Oct 13, 2021
Closed
@levrik
Copy link
Owner

levrik commented Oct 18, 2021

@limitedmage I've just updated the icons to v6. Could you please check if the icon is available in the just released v8 of mdi-react?

@limitedmage
Copy link
Author

@levrik Thank you, I'll take a look! Are there any breaking changes in v8?

@levrik
Copy link
Owner

levrik commented Oct 19, 2021

@limitedmage A major version bump of mdi causes a major version bump of mdi-react as well. No changes in mdi-react itself. Please check out the changes of mdi. I'm guessing some icons were removed and/or some were replaced by updated versions.

@limitedmage
Copy link
Author

@levrik Thanks so much for the quick response and the update. mdi-react is now up to date with the latest MDI and I'm updating our code on https://github.com/sourcegraph/sourcegraph/pull/26617 to update the library. There are some breaking changes but nothing super major 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@limitedmage @levrik