Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with prefer_recent variable in ref.sql #31

Closed
andreviniciusmb opened this issue Feb 17, 2024 · 2 comments · Fixed by #35
Closed

Error with prefer_recent variable in ref.sql #31

andreviniciusmb opened this issue Feb 17, 2024 · 2 comments · Fixed by #35

Comments

@andreviniciusmb
Copy link
Contributor

Context

I want to configure the preference to select the latest model (even though it is in dev) or not, and this can be done using the variable upstream_prod_prefer_recent.

Problem

Even setting the variable to False and not having the most up-to-date tables in my staging, the package continues to reference the tables in my staging.

Ex: As the prefer_recent variable is False and dev_exists is True, it could not be entered in the if command.

When I did this test checking if the variable was False, the if command did not enter.

@LewisDavies
Copy link
Owner

Thanks for catching this, and sorry for my slow reply. I've had this problem before when I haven't done a explicit comparison like prefer_recent == false - it's easy to miss because in Jinja it doesn't cause an error.

I've gone through the package and fixed any statements like this. I should be able to release a new version fixing this soon.

@LewisDavies
Copy link
Owner

@andreviniciusmb I've just merged a fix for this and will create a new release (v.0.8.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants