Periodically refresh cluster topology #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this early to move forward with the work, but retroactive reviews are welcome! 💟 |
jvf
reviewed
Mar 22, 2023
| ) | ||
|
|
||
| # "Reset" the load-balancing policy. | ||
| data = update_in(data.lbp, fn {lb_module, _} -> {lb_module, lb_module.init(peers)} end) |
There was a problem hiding this comment.
Maybe a good idea to only reset the load balancing if something changed?
There was a problem hiding this comment.
Good call, yes, we can do that 👍
| @@ -312,12 +400,9 @@ defmodule Xandra.Cluster.ControlConnection do | |||
| end | |||
|
|
|||
| # Discover the peers in the same data center as the node we're connected to. | |||
There was a problem hiding this comment.
The code looks to me like we are discovering all peers from all data centres, nut just the local one. Am I missing something?
There was a problem hiding this comment.
No, you're right, outdated comment. We'll need to re-add the DC-only functionality, which we'll do through load-balancing policies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jvf @harunzengin