Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO111MODULE needs to be set when building pillar #33

Closed
deitch opened this issue May 22, 2019 · 0 comments · Fixed by #34
Closed

GO111MODULE needs to be set when building pillar #33

deitch opened this issue May 22, 2019 · 0 comments · Fixed by #34

Comments

@deitch
Copy link
Contributor

deitch commented May 22, 2019

Description

When run in a docker container, we explicitly move out of the GOPATH to build. But when run locally, we run into build issues.

Steps to reproduce the issue:

go get github.com/lf-edge/eve
cd $GOPATH/src/github.com/lf-edge/eve
cd pkg/pillar
make zedbox

Describe the results you received:

Building dist/amd64/zedbox
go build -mod=vendor -ldflags -X=main.Version=-70860ff8-2019-05-22.09.52 -o dist/amd64/zedbox ./zedbox
build flag -mod=vendor only valid when using modules
make: *** [dist/amd64/zedbox] Error 1

Describe the results you expected:

It should build

Additional information you deem important (e.g. issue happens only occasionally):

Will open a PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant