Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info message sends blank DevId #97

Closed
deitch opened this issue Jun 18, 2019 · 6 comments
Closed

Info message sends blank DevId #97

deitch opened this issue Jun 18, 2019 · 6 comments

Comments

@deitch
Copy link
Contributor

deitch commented Jun 18, 2019

When sending an /info message, the DevId property should contain the UUID of the device, but the message is a "".

cc @eriknordmark @rvs

@eriknordmark
Copy link
Contributor

Looking at the code I see the info (device and app) as well as metrics messages all consistently using the zcdevUUID, which is set first from /config/uuid, and later potentially updated from the UUID in the reply to the GET of /config.

@deitch can you check that you are setting a uuid in the config payload, and what /config/uuid contains when using your controller?

@deitch
Copy link
Contributor Author

deitch commented Jun 20, 2019

It is possible that the config message was misconfigured. If so, that would do it. I will check it out early next week (traveling now).

@deitch
Copy link
Contributor Author

deitch commented Jun 20, 2019

Question: assuming this is the problem, should the device in some way validate the config to say, "I don't have a valid UUID" or "the UUID in this GET /config is different from the last one", and some way to tell the Controller that it has that issue?

@deitch
Copy link
Contributor Author

deitch commented Jun 26, 2019

I checked an actually zedcloud-generated config, it has the same structure, specifically:

{
  "id": {
    "uuid": "abcd-546-abcdf"
  }
}

The auto-generated one is:

{
  "id": {
    "uuid": "bd2c05c0-f7ec-4db3-9a54-acaea973ab43",
    "version": "4"
  }
}

So they do align. Looks like need to dig deeper.

@rvs
Copy link
Contributor

rvs commented Jun 26, 2019

@nordmark already fixed it in the EVE I believe

@eriknordmark
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants