Declarative Port Graph in C++ Runtime #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmnrd
reviewed
Jun 21, 2023
core/src/main/kotlin/org/lflang/generator/cpp/CppAssembleMethodGenerator.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/lflang/generator/cpp/CppAssembleMethodGenerator.kt
Outdated
Show resolved
Hide resolved
tanneberger
added
enhancement
tanneberger
force-pushed
the
cpp-connection-optimizations
branch
from
c630295
to
c284f60
Compare
cmnrd
approved these changes
Jul 27, 2023
updating reactor-cpp updating reactor-cpp update reactor-cpp
cmnrd
force-pushed
the
cpp-connection-optimizations
branch
from
ce53467
to
bb42523
Compare
petervdonovan
added
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declarative Port Graph
This pull requests adjusts the code generator to use the new port graph interface supplied by reactor-cpp.
Previously Ports and Connections were wired together directly by the code generator in the assembly method. This Pull-Request changes this behavior that connections between ports are not declared in the environment. This allows the environment to optimize a lot of connections away and then wire up the components.
Previously
Now
Also different Connection Types can be annotated over this interface like
ConnectionType::EnclavedDelayed,ConnectionType::PhysicalConnectionand many more.This PR works together with the changes in lf-lang/reactor-cpp/pull/51