Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of the RTI implementation #224

Merged
merged 32 commits into from
Jun 9, 2023
Merged

Refactoring of the RTI implementation #224

merged 32 commits into from
Jun 9, 2023

Conversation

ChadliaJerad
Copy link
Collaborator

RTI refactoring to separate common coordination functions between federates and enclaves.
There are two types of RTI instances, one for federates, and one for enclaves.

edwardalee and others added 14 commits May 21, 2023 12:30
@edwardalee
Very first pass on refactoring the RTI for enclaves
b091942
@edwardalee
Refactored more functions for enclave use.
0a1327a
@edwardalee
Added candidate next_event_tag function
82cccd9
@edwardalee
Added .vscode to .gitignore
533002c
@edwardalee
More refactoring
af9c247
@ChadliaJerad
Bringing commit 'Add enclaves RTI' from rti-enclaves to rti-refactoring
d14bc6f
@ChadliaJerad
Fix the memory allocation of the federates.
800a6f6
@ChadliaJerad
Fix segmentation fault, due to wrong access to enclaves using _RTI.
7bb3e3a
@ChadliaJerad
Merge branch 'main' into rti-refactoring
9e2613f
@ChadliaJerad
Merge updates from main
f601357
@ChadliaJerad
Fix the segmentation fault. Cycles are not yet correctly handled!
2a9e2e9
@ChadliaJerad
Separte federates RTI (_F_RTI) from enclave RTI (_E_RTI) and get rid …
9a72963 
…of all castings, except one.
@ChadliaJerad
Upstream and downstream attributes of a federate/enclave is and array…
241ffc3 
… of ids, and not an array of federates?!
@ChadliaJerad
Fix the very wrong variable name when requesting stop!
d918168
@ChadliaJerad
Copy link
Collaborator Author

Same case here for the tests.
Note this branch already merges updates from #228

@ChadliaJerad ChadliaJerad mentioned this pull request Jun 5, 2023
Merged
erlingrj
erlingrj reviewed Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting to look good. There is still a bunch of FIXMEs, some of them are probably out-dated though

.gitignore Outdated Show resolved Hide resolved
core/federated/RTI/enclave.c Outdated Show resolved Hide resolved
core/federated/RTI/enclave.c Outdated Show resolved Hide resolved
core/federated/RTI/enclave.c Outdated Show resolved Hide resolved
core/federated/RTI/rti_lib.h Outdated Show resolved Hide resolved
@erlingrj erlingrj mentioned this pull request Jun 7, 2023
Merged
12 tasks
@erlingrj
Copy link
Collaborator

erlingrj commented Jun 8, 2023

Conclusion at the meeting: LGTM so that we can get the other environment PRs merged also. Then we will continue working on the RTI in the future enclave branch which should bring it all together.

lhstrh
lhstrh reviewed Jun 8, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
lhstrh
lhstrh requested changes Jun 8, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I supplied some minor comments that should be easy to address.

core/federated/RTI/enclave.h Outdated Show resolved Hide resolved
core/federated/RTI/enclave_impl.c Outdated Show resolved Hide resolved
core/federated/RTI/rti_lib.c Outdated Show resolved Hide resolved
core/federated/RTI/rti_lib.h Outdated Show resolved Hide resolved
core/federated/RTI/rti_lib.h Outdated Show resolved Hide resolved
core/federated/RTI/enclave.c Show resolved Hide resolved
@lhstrh lhstrh merged commit 270e83c into main Jun 9, 2023
@lhstrh lhstrh deleted the rti-refactoring branch June 9, 2023 04:22
@ChadliaJerad ChadliaJerad mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlingrj erlingrj erlingrj left review comments

@lhstrh lhstrh lhstrh approved these changes

@edwardalee edwardalee Awaiting requested review from edwardalee

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChadliaJerad @erlingrj @edwardalee @lhstrh