Enable all warnings and treat them as errors #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move linking with threading library to low-level platform with PRIVATE - Remove the wierd REACTORC_COMPILE_DEFS variable - Dont add source files when they are not to be compiled - Add custom function for enabling warnings and -Werror
- printf %p must be casted to void* - comparison between signed and unsigned - unused function arguments - remove the empty trace macros - Add wrapper thread function for C11
…or-c into warnings-as-errors
lhstrh
reviewed
Mar 11, 2024
lhstrh
reviewed
Mar 11, 2024
|
@lhstrh and @edwardalee, I propose we merge this next so that the other PRs are forced to handle their warnings (and not having me do it afterwards in this PR). One change that I would like an extra set of eyes on is to the lf_thread_create in the C11 support. To avoid compiler warnings I had to define a wrapper function with a signature expected by the C11 (needs to return an int). |
edwardalee
approved these changes
Mar 17, 2024
petervdonovan
approved these changes
Mar 17, 2024
erlingrj
commented
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I enable all warnings and treat them as errors with
-Wall -Wpedantic -Werror, this is how it is done in reactor-cpp. This triggered some refactoring of the CMake system and addressing a lot of warnings all over the code-base. I expect there to be a lot more warnings when CI run tests on Windows, macOS, Zephyr etc.The advantage of getting this merged is that it puts more requirements on the code that is checked in. The next step is to add clang-tidy which performs static analysis and catches even more possible undefined behaviour.
Disabled on the following platforms: