TracePluginProperty fixes #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit results from changes that were made in the effort to eliminate warnings. The changes were good, but the problem that I have is that I wish for everything that will be used by code outside of the runtime to be in the trace/api directory.
|
The fixmes in the description of this PR seem things that need to be addressed on the Lingua Franca end, are they not? |
lhstrh
reviewed
May 8, 2024
lhstrh
approved these changes
May 8, 2024
|
I am going to double check why this was working in other projects.
ons. 8. mai 2024 kl. 22:13 skrev Marten Lohstroh ***@***.***>:
… ***@***.**** approved this pull request.
Looks great! Thanks, @erlingrj <https://github.com/erlingrj>.
—
Reply to this email directly, view it on GitHub
<#420 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFBXI4XMG6INLAVWAZQV5Y3ZBKBQDAVCNFSM6AAAAABHLF7FH6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBWGU2TINRXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to compile a simple example with an external trace plugin I got linker errors. It seems that we need to link with
dl. I am not exactly sure why it has worked before without specifying this though.