Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run one worker on main thread #437

Merged
merged 3 commits into from
May 26, 2024
Merged

Run one worker on main thread #437

merged 3 commits into from
May 26, 2024

Conversation

sberkun
Copy link
Collaborator

@sberkun sberkun commented May 25, 2024

Replaces #375

Runs a worker on the main thread, allowing number of workers to equal number of cores. This is important for the RP2040 and FlexPRET.

As a followup to this, the CMake check for flexpret should be adjusted so that it allows workers=threads rather than workers=threads-1.

@sberkun sberkun added the enhancement Enhancement of existing feature label May 25, 2024
@sberkun sberkun requested a review from edwardalee May 25, 2024 14:47
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge this!

@sberkun sberkun enabled auto-merge May 26, 2024 08:43
@sberkun sberkun added this pull request to the merge queue May 26, 2024
Merged via the queue into main with commit c30161c May 26, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants