Tune unit tests (issue #333) #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgatto
reviewed
Apr 12, 2018
tests/testthat/test_MSnExp.R
Outdated
| k = 1) | ||
| ## Reduce the TMT erwinia data set to speed up processing on the full | ||
| ## data. | ||
| tmt <- filterMz(filterRt(tmt_erwinia_in_mem_ms1, c(1200, 1250)), |
There was a problem hiding this comment.
How much do you gain from sub-setting along M/Z? I would keep it so that we actually pick peaks along the whole M/Z range. Filtering along the retention time makes sense, as we repeat the same operation many times.
There was a problem hiding this comment.
You're right. For MSnExp we probably don't gain much. I'll keep that to filterRt and also define the filtered objects in testthat.R as you suggest.
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
======================================
Coverage 76.7% 76.7%
======================================
Files 79 79
Lines 8642 8642
======================================
Hits 6629 6629
Misses 2013 2013Continue to review full report at Codecov.
|
lgatto
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #333 for details about this PR. Performance of unit tests was improved by sub-setting large data files.